Skip to content

frontend: storybook: Add descriptive titles to AuthToken stories#4676

Open
mastermaxx03 wants to merge 1 commit intokubernetes-sigs:mainfrom
mastermaxx03:fix/chooser-dialogtitle-a11y
Open

frontend: storybook: Add descriptive titles to AuthToken stories#4676
mastermaxx03 wants to merge 1 commit intokubernetes-sigs:mainfrom
mastermaxx03:fix/chooser-dialogtitle-a11y

Conversation

@mastermaxx03
Copy link
Contributor

@mastermaxx03 mastermaxx03 commented Feb 11, 2026

Summary

Changed AuthToken story titles from generic "a title" to "Authentication Token" and "Authentication Error" to fix accessibility violations.

Related Issue

Fixes #4594, #4595

Changes

  • Updated placeholder title to "Authentication Error" in the ShowError story.
  • Updated placeholder title to "Authentication Token" in the ShowActions story.
  • Regenerated storybook snapshots to reflect title changes.

Screenshots

Authentication Token Authentication Error
Auth Error Auth Token

Steps to Test

  1. Run npm run storybook in the frontend directory.
  2. Navigate to AuthToken in the sidebar.
  3. Check ShowError and ShowActions stories to verify the titles are no longer placeholders.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mastermaxx03
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2026
@mastermaxx03 mastermaxx03 force-pushed the fix/chooser-dialogtitle-a11y branch from 10b987f to 148fc13 Compare February 11, 2026 18:17
@mastermaxx03
Copy link
Contributor Author

mastermaxx03 commented Feb 11, 2026

@illume I think the simplest solution to fix the two issues was to change the titles manually. Let me know if this works!

@illume
Copy link
Contributor

illume commented Feb 11, 2026

Hello.

unfortunately this is not right. Have a look at this snapshot file to see the heading levels.

it should be

h1
.. h2
.. h2

I see in this snapshot that the h1 is after the h2, and that some headings are empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquimrocha joaquimrocha Awaiting requested review from joaquimrocha

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

3 participants

@mastermaxx03 @k8s-ci-robot @illume